feat: autoinstall Angular v17 #5367
Conversation
| "plugins": [ | ||
| { | ||
| "packageName": "@netlify/angular-runtime", | ||
| "condition": { "minNodeVersion": "17.0.0" } |
There was a problem hiding this comment.
Is this what you meant to do?
There was a problem hiding this comment.
nope, it isn't! I meant to do "from angular v17 on, use this". gonna look at how to do that. good catch!´
There was a problem hiding this comment.
It's changed since I last worked on it, so I'm afraid I can't help there!
There was a problem hiding this comment.
implemented minFrameworkVersion in e6298e9
minFrameworkVersion
|
I'm pretty sure the versioning must already be implemented elsewhere though. We're installing different versions of the Next.js runtime according to which version of next it is, so that logic must be somewhere! It used to be in plugins.json, but I think it's in the CMS now |
|
We have versioning implemented + configured via |
minFrameworkVersion|
Lukas reminded me that we're not using framework-info anymore. Good news, because build-info makes this change a lot simpler! |
|
I'm pretty confident in the approach based on tests. Will merge now in the interest of time, let's address any feedback lukas might have in a follow-up. |
In netlify/angular-runtime#67, we're working on improved Angular support for v17+. This PR adds auto-install for the package.
To be merged after netlify/angular-runtime#67 is done + released.