feat: leverage errors types for tracing #5365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4962a23 to
4f29043
Compare
|
This pull request adds or modifies JavaScript ( |
JGAntunes
approved these changes
Nov 6, 2023
Comment on lines
+36
to
+41
| const { | ||
| errorInfo: { location: { packageName } = {} }, | ||
| message, | ||
| title, | ||
| type, | ||
| } = fullErrorInfo |
There was a problem hiding this comment.
For reference I double checked and seems like the errorInfo is always populated:
Comment on lines
+58
to
+63
| const cancellationAttributes = { | ||
| 'build.cancellation.title': title, | ||
| 'build.cancellation.message': message, | ||
| 'build.cancellation.packageName': packageName, | ||
| } | ||
| addEventToActiveSpan('build.cancelled', cancellationAttributes) |
There was a problem hiding this comment.
Just adding a mental note that we'll want to test this out once it lands in prod 👌
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
This was referenced Jun 5, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://linear.app/netlify/issue/COM-91/leverage-error-types-in-netlifybuild