Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secret-scanning): secret detection should produce an user error #5354

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

JGAntunes
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Secret detection should produce an user error n ot a system one


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@JGAntunes JGAntunes self-assigned this Oct 25, 2023
@JGAntunes JGAntunes requested review from a team as code owners October 25, 2023 16:28
@github-actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@kodiakhq kodiakhq bot merged commit 0458ea7 into main Oct 26, 2023
@kodiakhq kodiakhq bot deleted the fix/COM-87-secret-scanning-user-error branch October 26, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants