Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for loading a tracing baggage dump in WC3 Baggage format #5343

Merged
merged 8 commits into from
Oct 26, 2023
Merged

feat: Add support for loading a tracing baggage dump in WC3 Baggage format #5343

merged 8 commits into from
Oct 26, 2023

Conversation

4xposed
Copy link
Contributor

@4xposed 4xposed commented Oct 20, 2023

@4xposed 4xposed requested review from a team as code owners October 20, 2023 08:44
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Oct 20, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@github-actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@4xposed 4xposed force-pushed the daniel/receive_telemetry_baggage_from_buildbot branch 3 times, most recently from c790459 to 75e1426 Compare October 20, 2023 10:06
@4xposed 4xposed changed the title [WIP] feat: Add support for loading a tracing baggage dump in WC3 Baggage format feat: Add support for loading a tracing baggage dump in WC3 Baggage format Oct 20, 2023
@4xposed 4xposed force-pushed the daniel/receive_telemetry_baggage_from_buildbot branch 2 times, most recently from 609f35e to aa89706 Compare October 20, 2023 11:16
@4xposed 4xposed marked this pull request as draft October 20, 2023 23:43
@4xposed 4xposed force-pushed the daniel/receive_telemetry_baggage_from_buildbot branch from c36e674 to 1955ea5 Compare October 24, 2023 08:51
@4xposed 4xposed force-pushed the daniel/receive_telemetry_baggage_from_buildbot branch from 1955ea5 to 7bf5ee9 Compare October 24, 2023 08:57
@4xposed 4xposed marked this pull request as ready for review October 24, 2023 13:07
JGAntunes
JGAntunes reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@JGAntunes JGAntunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small suggestions, let me know what you think

packages/build/tests/tracing/tests.js Outdated Show resolved Hide resolved
packages/build/tests/tracing/tests.js Outdated Show resolved Hide resolved
packages/build/tests/tracing/tests.js Outdated Show resolved Hide resolved
JGAntunes
JGAntunes previously approved these changes Oct 25, 2023
View reviewed changes
@4xposed
Copy link
Contributor Author

4xposed commented Oct 25, 2023

@JGAntunes I need another review 🙏

I had some variable shadowing which failed the previous test run: 500201d

@4xposed 4xposed enabled auto-merge (squash) October 25, 2023 14:40
@4xposed 4xposed merged commit 3d64536 into main Oct 26, 2023
35 checks passed
@4xposed 4xposed deleted the daniel/receive_telemetry_baggage_from_buildbot branch October 26, 2023 07:28
@netlify-circleci netlify-circleci mentioned this pull request Oct 26, 2023
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
This was referenced Jun 5, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGAntunes JGAntunes JGAntunes approved these changes

Assignees
No one assigned
Labels
Adds or modifies js files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4xposed @JGAntunes