feat: fetch integrations only when online

netlify · Nov 10, 2023 · fc1c071 · fc1c071
1 parent d7a432c
commit fc1c071
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 5 deletions.
diff --git a/packages/config/src/api/integrations.ts b/packages/config/src/api/integrations.ts
@@ -10,11 +10,16 @@ type AvailableIntegration = {
 
 type GetAvailableIntegrationsOpts = {
   testOpts: TestOptions
+  offline: boolean
 }
 
 export const getAvailableIntegrations = async function ({
   testOpts,
+  offline,
 }: GetAvailableIntegrationsOpts): Promise<AvailableIntegration[]> {
+  if (offline) {
+    return []
+  }
   const { host } = testOpts
   const baseUrl = new URL(host ? `http://${host}/` : `https://api.netlifysdk.com/`)
 

diff --git a/packages/config/src/api/site_info.ts b/packages/config/src/api/site_info.ts
@@ -38,7 +38,7 @@ export const getSiteInfo = async function ({
   if (api === undefined || mode === 'buildbot' || testEnv) {
     const siteInfo = siteId === undefined ? {} : { id: siteId }
 
-    const integrations = mode === 'buildbot' && !offline ? await getIntegrations({ siteId, testOpts }) : []
+    const integrations = mode === 'buildbot' && !offline ? await getIntegrations({ siteId, testOpts, offline }) : []
 
     return { siteInfo, accounts: [], addons: [], integrations }
   }
@@ -47,7 +47,7 @@ export const getSiteInfo = async function ({
     getSite(api, siteId, siteFeatureFlagPrefix),
     getAccounts(api),
     getAddons(api, siteId),
-    getIntegrations({ siteId, testOpts }),
+    getIntegrations({ siteId, testOpts, offline }),
   ]
 
   const [siteInfo, accounts, addons, integrations] = await Promise.all(promises)
@@ -99,10 +99,15 @@ const getAddons = async function (api: NetlifyAPI, siteId: string) {
 type GetIntegrationsOpts = {
   siteId?: string
   testOpts: TestOptions
+  offline: boolean
 }
 
-const getIntegrations = async function ({ siteId, testOpts }: GetIntegrationsOpts): Promise<IntegrationResponse[]> {
-  if (!siteId) {
+const getIntegrations = async function ({
+  siteId,
+  testOpts,
+  offline,
+}: GetIntegrationsOpts): Promise<IntegrationResponse[]> {
+  if (!siteId || offline) {
     return []
   }
 

diff --git a/packages/config/src/integrations.ts b/packages/config/src/integrations.ts
@@ -8,15 +8,17 @@ type MergeIntegrationsOpts = {
   apiIntegrations: IntegrationResponse[]
   context: string
   testOpts?: TestOptions
+  offline: boolean
 }
 
 export const mergeIntegrations = async function ({
   configIntegrations = [],
   apiIntegrations,
   context,
   testOpts = {},
+  offline,
 }: MergeIntegrationsOpts): Promise<Integration[]> {
-  const availableIntegrations = await getAvailableIntegrations({ testOpts })
+  const availableIntegrations = await getAvailableIntegrations({ testOpts, offline })
 
   // Include all API integrations, unless they have a `dev` property and we are in the `dev` context
   const resolvedApiIntegrations = apiIntegrations.filter(

diff --git a/packages/config/src/main.ts b/packages/config/src/main.ts
@@ -122,6 +122,7 @@ export const resolveConfig = async function (opts) {
     configIntegrations: configA.integrations,
     context: context,
     testOpts,
+    offline,
   })
 
   const result = {