This repository has been archived by the owner on Oct 10, 2022. It is now read-only.
feat: detect js workspaces #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return {} | ||
| } | ||
|
|
||
| const buildInfo = async function (context) { |
There was a problem hiding this comment.
[sand] Am I right in thinking that this function exists because in the future buildInfo may return more data, which it will collect from functions other than getWorkspaceInfo. If so, would it make sense for getWorkspaceInfo to return just the data (e.g. return { isRoot, packages }) and let buildInfo be in charge of defining the keys it exposes?
There was a problem hiding this comment.
Good point 👍 addressed via 27af306
4a8a7be to
62ea544
Compare
9c3cf68 to
baa1e00
Compare
baa1e00 to
c46f488
Compare
eduardoboucas
approved these changes
Mar 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to detect
js-workspaces:We're currently detecting 2 scenarios. The first one is if your project is actually building from a root workspaces project (not making use of the base property config). The second scenario is if you're pointing to a project that is a workspace itself, with the root
package.jsonpresent in the root of the repo.I've opted for using the
map-workspacesproject fromnpm, as it provides the paths for the workspaces out of the box and handles the glob expansion. Even though we're not planning to use thepathsright away I figured it's a useful bit of info that we're probably going to rely on a near future. Also added a flag to distinguish if a project is pointing to the workspaces root, or is actually a workspace itself.