Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP and HTTPS support to the simple exporting connector #9911

Merged
merged 46 commits into from
Nov 5, 2020

Conversation

vlvkobal
Copy link
Contributor

@vlvkobal vlvkobal commented Sep 10, 2020

Summary

There is a group of exporting connectors that use the same base - the simple connector:

  • Graphite
  • JSON
  • OpenTSDB
  • Prometheus Remote Write

We are adding HTTP and HTTPS support to this group and fixing a bunch of bugs along the way.

  • Use a ring buffer for the simple connector
  • Support for HTTP protocol in the Graphite and JSON connectors
  • Support for HTTPS in the Graphite, JSON, and Prometheus Remote Write connectors
  • Send HTTP headers once per batch
  • Use a correct JSON list format
  • Compact OpenTSDB HTTP output
  • Use functions from the exporting engine for the allmetrics API call with Prometheus format

Fixes #9607
Fixes #9631
Closes #9189
Fixes #10057

Component Name

exporting engine

Test Plan

Test the exporting engine with every protocol (plain, http, https) for the Graphite, JSON, OpenTSDB, and Prometheus Remote Write connectors.

Check the output of allmetrics?format=prometheus API request.

exporting/send_data.c Outdated Show resolved Hide resolved
exporting/send_data.c Outdated Show resolved Hide resolved
exporting/send_data.c Outdated Show resolved Hide resolved
@vlvkobal
Copy link
Contributor Author

when I am using this PR and instead to use OpenTSDB I use InfluxDB, I always receive the alarm

I confirm. Something is wrong with the statistics:
image

@vlvkobal
Copy link
Contributor Author

vlvkobal commented Nov 2, 2020

The statistics should work correctly after the last fix.

thiagoftsm
thiagoftsm previously approved these changes Nov 2, 2020
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the last commits, all the problems were fixed and concerns removed. I did not identify any problem with the tests, but I was not able to test Graphana.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants