-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP and HTTPS support to the simple exporting connector #9911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoftsm
reviewed
Oct 30, 2020
thiagoftsm
reviewed
Oct 30, 2020
thiagoftsm
reviewed
Oct 30, 2020
The statistics should work correctly after the last fix. |
thiagoftsm
previously approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the last commits, all the problems were fixed and concerns removed. I did not identify any problem with the tests, but I was not able to test Graphana.
stelfrag
reviewed
Nov 4, 2020
thiagoftsm
approved these changes
Nov 4, 2020
mfundul
approved these changes
Nov 5, 2020
stelfrag
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a group of exporting connectors that use the same base - the simple connector:
We are adding HTTP and HTTPS support to this group and fixing a bunch of bugs along the way.
Fixes #9607
Fixes #9631
Closes #9189
Fixes #10057
Component Name
exporting engine
Test Plan
Test the exporting engine with every protocol (plain, http, https) for the Graphite, JSON, OpenTSDB, and Prometheus Remote Write connectors.
Check the output of
allmetrics?format=prometheus
API request.