-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add claimed_id
for child nodes streamed to their parents
#9804
Conversation
Overall it looks ok, I know it is still |
this is topology of the 4 layer test However during testing I tried different combinations (especially with claiming/unclaiming nodes) and topologies |
Ok good, now the test plan is comprehensive. I'll let the other reviewer take a look before I go back for a second look at the code. |
I've disabled the Codacy warnings as they are just noise - it does not understand the loop macro for some reason. |
@Ferroin arch CI build started failing yesterday with unrelated error: Can you take a look if you have 5' |
I checked also with production that it doesnt kill something just to be paranoid before merge. |
claimed_id
for child nodes streamed to their parents
Summary
claimed_id of nodes is streamed to parents. For easy testing also added to
![Screenshot from 2020-08-25 11-38-41](https://user-images.githubusercontent.com/6674623/91158903-9a4f7380-e6c7-11ea-8c7d-07491b08c330.png)
/api/v1/info
(where cloud will need it anyway sooner or later)Example of 3-level streaming from the view of top-level parent:
Component Name
Streaming
Test Plan
Have some streaming setup and look at
/api/v1/info
. Check nothing breaks with Cloud by connecting this node tostaging.netdata.cloud
. Claim nodes and see if their claiming Id propagates up the network by checking/api/v1/info
of the topmost node. All nodes have to be running this PR for it to work.What was tested together with the cloud team:
mirrored_hosts_status
field) is send to cloud as part ofonconnect
payload over ACLKWhat was tested additionally:
netdatacli reload-claiming-state
TopLevelMaster
(VM,not claimed)timowss
(real machine,claimed) ->TopLevelMaster
(VM)Fed32-Layer1Host1
(VM,claimed) ->timowss
(real machine, claimed)Fed32-Layer1Host2
(VM,not claimed) ->timowss
(real machine, claimed)Fed32-Layer2Host1
(VM,not claimed) ->Fed21-Layer1Host1
(VM, claimed)Additional Information
Codacy false triggers here. It doesn't seem to recognize
rrdhost_foreach_read
macro is a loop and as a result, thinksif(count > 0) {
is always false (which is not true).