Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed RPM default permissions for /usr/libexec/netdata #9621

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Fixed RPM default permissions for /usr/libexec/netdata #9621

merged 1 commit into from
Jul 30, 2020

Conversation

Saruspete
Copy link
Contributor

Summary

Fixes #9620 : bad default permission in specfile lead to all files in /usr/libexec/netdata to be setuid.

Component Name

netdata.spec.in

Test Plan
git clone https://github.com/netdata/netdata.git
cd netdata
./contrib/rhel/build-netdata-rpm.sh
rpm -qvlp ~/rpmbuild/RPMS/x86_64/netdata-*.rpm | grep /usr/libexec/netdata
Additional Information

@squash-labs
Copy link

squash-labs bot commented Jul 28, 2020

Manage this branch in Squash

Test this branch here: https://saruspetefix-rpmspec-a1ygf.squash.io

@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Jul 28, 2020
@prologic
Copy link
Contributor

@Ferroin Please review and merge.

@Ferroin Ferroin changed the title Fix netdata.spec.in default permissions for /usr/libexec/netdata Fixed RPM default permissions for /usr/libexec/netdata Jul 30, 2020
@Ferroin Ferroin merged commit 95e0339 into netdata:master Jul 30, 2020
@Saruspete Saruspete deleted the fix_rpmspec branch July 30, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ferroin Ferroin Ferroin approved these changes

@prologic prologic prologic approved these changes

@amoss amoss Awaiting requested review from amoss

Assignees

@Ferroin Ferroin

@prologic prologic

Labels
area/packaging Packaging and operating systems support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[netdata.spec] rpm package has bad default permissions 4750 to all files in /usr/libexec/netdata
3 participants
@Saruspete @prologic @Ferroin