Delay child disconnect update #18712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58b900f to
ece8858
Compare
thiagoftsm
previously approved these changes
Oct 8, 2024
|
Dealing with an issue on older systems... |
Assume the child will return at 125% of that time Add timers to handle scheduluing of the node update events to the cloud Handle faster reconnection and reschedule timer to correct state
ece8858 to
1a99ba0
Compare
|
It looks like our sqlite has an issue: In function 'sqlite3Strlen30',
inlined from 'sqlite3ColumnSetColl' at /home/thiago/Netdata/tests_netdata/src/database/sqlite/sqlite3.c:121492:10:
/home/thiago/Netdata/tests_netdata/src/database/sqlite/sqlite3.c:34720:28: warning: 'strlen' reading 1 or more bytes from a region of size 0 [-Wstringop-overread]
34720 | return 0x3fffffff & (int)strlen(z);
| ^~~~~~~~~We should update it when it is possible. |
thiagoftsm
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a child node disconnects from a parent delay sending the disconnect message to the cloud expecting the child
will be restarting.
The parent will use information from the child (start and shutdown times) to calculate when the child is expected to reconnect before sending out the message to the cloud.
It will wait
(start + shutdown) * 1.25seconds (max of 30 seconds) before sending the message.