Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address_comments: Get different PIDs levels #375

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

thiagoftsm
Copy link
Contributor

@thiagoftsm thiagoftsm commented Mar 29, 2024

Summary

Address a comment in netdata/netdata#17073.

Test Plan
  1. Get binaries according to your C library from this link and extract them inside a directory, for example: ../artifacts.
    You can also get everything for glibc [here](UPLOAD FILE WITH ALL BINARIES TO SIMPLIFY REVIEWERS).

  2. Extract them running:

    $ for i in `ls *.zip`; do unzip $i; rm .gitkeep ; rm $i; done
    $ for i in `ls *.xz`; do tar -xf $i; rm $i* ; done
  3. Compile branch an run the following tests:

    # make clean; make tester
    # for i in `seq 0 3`; do ./kernel/legacy_test --networkviewer --netdata-path ../artifacts --content --iteration 1 --pid $i --log-path file_pid$i.txt; done
  4. Every test should ends with Success, unless you do not have a specific target (function) available.

Additional information

This PR was tested on:

Linux Distribution Environment Kernel Version Real Parent Parent All PIDs Without PIDs
Slackware current Bare metal 6.6.22 slackware_pid0.txt slackware_pid1.txt slackware_pid2.txt slackware_pid3.txt

@thiagoftsm thiagoftsm requested a review from Ferroin as a code owner March 29, 2024 22:56
@thiagoftsm thiagoftsm merged commit 1cd2e6b into netdata:master Mar 29, 2024
38 checks passed
@thiagoftsm thiagoftsm deleted the address_comments branch March 29, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant