Network Viewer program (bandwidth) #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
, this is the basis of network viewer
This commit brings a map for a necessary function to work with sockets
This commit brings the global charts to the collector
Brings missing comments for the collector
mfundul
reviewed
May 27, 2020
mfundul
reviewed
May 27, 2020
| /** | ||
| * https://elixir.bootlin.com/linux/v5.6.14/source/net/ipv4/udp.c#L965 | ||
| */ | ||
| #if NETDATASEL < 2 |
There was a problem hiding this comment.
Is there a reason why we support both modes with kprobes? What's the industry standard for this type of monitoring? Maybe we can copy what most people are doing if it doesn't make much difference. In any case I don't see why we need to have 2 separate binaries for every collector, when we could just have one binary.
There was a problem hiding this comment.
The standard is not monitor errors, but I am bringing both to demonstrate users number of errors for these probes. This will also be used in the future with the developer log.
mfundul
previously approved these changes
May 27, 2020
mfundul
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of netdata/netdata#8730 .
eBPF program to store socket information , this is the basis of network viewer, but the focus of this PR is to store information related to the bandwidth.