Closes #16971: Add system jobs #17716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alehaa I think we might have jumped the gun a bit on FR #16971: Because this is introducing a new plugin capability, it needs to be tagged for a minor release. (We can't ship any changes to the plugins API in a patch release.) I have no issue tagging for v4.2 though. Are okay with rebasing this against the |
|
That's fine by me. Do you initiate the rebase or do I have to do it locally and submit a new PR? |
|
I should be able to tackle the rebase, just wanted to give you a heads up. |
bf88f18 to
5b61d14
Compare
5b61d14 to
191552f
Compare
191552f to
3091fa5
Compare
If a job is to be enqueued once and no specific scheduled time is specified, any scheduled time of existing jobs will be valid. Only if a specific scheduled time is specified for 'enqueue_once()' can it be evaluated.
A new registry key allows background system jobs to be registered and automatically scheduled when rqworker starts.
The documentation reflected a non-production state of the JobRunner framework left over from development. Now a more practical example demonstrates the usage.
To clarify which meta-attributes belong to system jobs, each of them is now prefixed with 'system_'.
3091fa5 to
8a8c328
Compare
bctiemann
approved these changes
Oct 21, 2024
arthanson
requested changes
Oct 21, 2024
jeremystretch
requested changes
Oct 25, 2024
Previously, the 'system_enabled' attribute was used to control whether a job should run or not. However, this can also be accomplished by evaluating the job's interval.
alehaa
commented
Oct 30, 2024
alehaa
commented
Oct 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16971
This PR allows the NetBox core and plugins to register job runners as system jobs. These are automatically scheduled without UI interaction, just before the worker process starts. This allows job runners to be used for housekeeping and synchronization tasks in future commits.