15635 filter search results if deactivated plugin #15693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Apr 15, 2024
| # Construct the base queryset to retrieve matching results | ||
| queryset = CachedValue.objects.filter(query_filter).annotate( | ||
| queryset = CachedValue.objects.filter(object_type_id__in=content_type_ids).filter(query_filter).annotate( |
There was a problem hiding this comment.
This introduces significant overhead to the query. We should explore options for a more elegant approach, which will probably entail prescribing a process for clearing cached values for plugins that have been removed.
|
Closing as fixed by documentation change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15635
Update search to exclude any records which refer to an instance of a model that's no longer installed. This can happen when a plugin is removed but its data remains in the database, for example.