Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #14365: Introduce job_start and job_end signals #14393

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Closes #14365: Introduce job_start and job_end signals #14393

merged 2 commits into from
Dec 1, 2023

Conversation

jeremystretch
Copy link
Member

Closes: #14365

  • Introduce two new signals in core: job_start and job_end
  • Move Job.process_event() logic for EventRule processing to receiver functions under extras

arthanson
arthanson requested changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just remove the core.pre_sync or document in signals.md

docs/development/signals.md Show resolved Hide resolved
@jeremystretch jeremystretch added this to the v3.7 milestone Dec 1, 2023
@jeremystretch jeremystretch merged commit 4fc0a99 into feature Dec 1, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 14365-job-signals branch December 1, 2023 00:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arthanson arthanson arthanson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremystretch @arthanson