N+1 issue on the /api/ipam/ip-addresses/ endpoint

[mulmat]

Deployment Type

Self-hosted

NetBox Version

v3.7.6

Python Version

3.10

Steps to Reproduce

Call the /api/ipam/ip-addresses/ endpoint with more than 1 assigned ip address in the database (important that the ip addresses are assigned and you are listing assigned ip addresses, for example by using assigned_to_interface=true filter)

Expected Behavior

No N+1 issue.

I can submit I PR if wanted (I think the issue is that IPAddressViewSet are missing assigned_object_type in the prefetch_related)

Observed Behavior

N+1 issue with the following query:

SELECT ••• FROM "django_content_type" WHERE "django_content_type"."id" = X LIMIT 21

[jeremystretch]

Thank you for opening a bug report. I was unable to reproduce the reported behavior on NetBox v3.7.6. Please re-confirm the reported behavior on the current stable release and adjust your post above as necessary. Remember to provide detailed steps that someone else can follow using a clean installation of NetBox to reproduce the issue. Remember to include the steps taken to create any initial objects or other data.

[mulmat]

@jeremystretch - forgot to mention that the ips must be assigned. I've updated the post now above + also verified that the issue also affects 3.7.6

As a reference, I created ips like this to reproduce the issue:

IPAddress.objects.create(
    address=ip,
    assigned_object_type=ContentType.objects.get(app_label="dcim", model="interface"),
    assigned_object_id=52,
)

[mulmat]

@jeremystretch - I can fix a PR for this

[jeremystretch]

@mulmat thanks, I've assigned this to you. A word of caution: be aware that the tables wipe out any prefetches set on the view's queryset, so addressing this will likely need work on the column itself.

[mulmat]

@mulmat thanks, I've assigned this to you. A word of caution: be aware that the tables wipe out any prefetches set on the view's queryset, so addressing this will likely need work on the column itself.

Since this in in the api part I think #15886 should be enough? Or did you also discover this to be an issue in the IPAddressListView view? @jeremystretch

[jeremystretch]

Sorry; I had it in my head that this was for the UI. Disregard my note above!