Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PostgreSQL resources for L2VPN models #15401

Closed
jeremystretch opened this issue Mar 11, 2024 · 0 comments
Closed

Rename PostgreSQL resources for L2VPN models #15401

jeremystretch opened this issue Mar 11, 2024 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v4.0

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Rename the following sequence tables:

  • ipam_l2vpn_export_targets_id_seq
  • ipam_l2vpn_id_seq
  • ipam_l2vpn_import_targets_id_seq
  • ipam_l2vpntermination_id_seq

As well as the following indexes & constraints:

  • ipam_l2vpn_pkey
  • ipam_l2vpn_name_5e1c080f_like
  • ipam_l2vpn_name_key
  • ipam_l2vpn_slug_24008406_like
  • ipam_l2vpn_slug_24008406_uniq
  • ipam_l2vpn_tenant_id_bb2564a6
  • ipam_l2vpn_tenant_id_bb2564a6_fk_tenancy_tenant_id
  • ipam_l2vpntermination_pkey
  • ipam_l2vpntermination_assigned_object_type_id_3923c124
  • ipam_l2vpntermination_l2vpn_id_9e570aa1
  • ipam_l2vpntermination_assigned_object_id_check
  • ipam_l2vpnterminatio_assigned_object_type_3923c124_fk_django_co
  • ipam_l2vpntermination_l2vpn_id_9e570aa1_fk_ipam_l2vpn_id

Justification

The L2VPN and L2VPNTermination models were migrated from the ipam app to the vpn app in NetBox v3.7, and their corresponding tables in the PostgreSQL database were renamed accordingly. However, Django does not automatically rename their accompanying sequence tables, indexes, or constraints.

Although retaining the original names for these resources has no functional impact, they should be renamed to match their tables to avoid potential confusion.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Mar 11, 2024
@jeremystretch jeremystretch added this to the v4.0 milestone Mar 11, 2024
@jeremystretch jeremystretch self-assigned this Mar 11, 2024
jeremystretch added a commit that referenced this issue Mar 11, 2024
@jeremystretch
Closes #15401: Rename PostgreSQL tables & indexes for L2VPN models
e20ba2f
@jeremystretch jeremystretch mentioned this issue Mar 11, 2024
Merged
jeremystretch added a commit that referenced this issue Mar 12, 2024
@jeremystretch
Closes #15401: Rename PostgreSQL tables & indexes for L2VPN models (#…
52bda9c 
…15405)

* Closes #15401: Rename PostgreSQL tables & indexes for L2VPN models

* Account for alternate index name
@jeremystretch jeremystretch mentioned this issue May 6, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
1 participant
@jeremystretch