Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing prefix to invalid value shows no warning #136

Closed
bellwood opened this issue Jun 30, 2016 · 1 comment
Closed

Editing prefix to invalid value shows no warning #136

bellwood opened this issue Jun 30, 2016 · 1 comment
Labels
type: bug A confirmed report of unexpected behavior in the application

Comments

@bellwood
Copy link
Contributor

bellwood commented Jun 30, 2016 •
edited
Loading

I have 10.175.0.0/16 listed a prefix under the 10.0.0.0/8 aggregate

When I try to edit 10.175.0.0/16 to 10.175.1.1/16 it tells me:

Modified prefix 10.175.0.0/16

Presumably this is because 10.175.1.1/16 is invalid (which is fine) but it should be a catchable/reportable error.
@bellwood bellwood changed the title [BUG] Cannot edit prefix / no warning [BUG] Edit prefix to invalid value no warning Jun 30, 2016
@mdlayher mdlayher added the type: bug A confirmed report of unexpected behavior in the application label Jun 30, 2016
@mdlayher mdlayher changed the title [BUG] Edit prefix to invalid value no warning Editing prefix to invalid value shows no warning Jun 30, 2016
@jeremystretch
Copy link
Member

Good point. Makes more sense to display the likely intended prefix rather that silently fixing it.

netbox_-add_a_new_prefix-_2016-06-30_17 07 39

@jeremystretch jeremystretch mentioned this issue Jun 30, 2016
Merged
if-fi pushed a commit to if-fi/netbox that referenced this issue Oct 1, 2016
@jeremystretch
Fixes netbox-community#136: Trigger error on prefix w/host bits set i…
5d2d106 
…nstead of silently converting it
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdlayher @bellwood @jeremystretch