Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Python files from ConfigMap #327

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Split Python files from ConfigMap #327

merged 3 commits into from
Sep 9, 2024

Conversation

LeoColomb
Copy link
Member

@LeoColomb LeoColomb commented Sep 5, 2024

The purpose of this PR is to isolate Python files used in the Helm chart to apply usual tests and checks on them.
This should help to maintain these scripts:

From a more opinionated PoV, I believe keeping Python files away from Helm chart templating would ensure more stable scripts and less breaking changes there.

@LeoColomb LeoColomb marked this pull request as ready for review September 9, 2024 20:35
@LeoColomb LeoColomb force-pushed the leo/feat/files branch 3 times, most recently from 5ebd9e8 to 2330052 Compare September 9, 2024 22:27
@LeoColomb LeoColomb enabled auto-merge (rebase) September 9, 2024 22:33
@LeoColomb LeoColomb merged commit 5b09e01 into develop Sep 9, 2024
20 checks passed
@LeoColomb LeoColomb deleted the leo/feat/files branch September 9, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants