bugfix: parse --debug before using it

[powerjungle]

The arg_debug flag is set after some functions check for it.

firejail/src/firejail/main.c

Line 1347 in f27775c

arg_debug = 1;

An example of a function in this situation is check_kernel_procs().

firejail/src/firejail/main.c

Line 1129 in f27775c

int rv = check_kernel_procs();

firejail/src/firejail/no_sandbox.c

Line 102 in f27775c

if (arg_debug)

[kmk3]

I see that you reworded the commit message (and undid it).

I was trying to improve the grammar with my force-push, but now I'm not sure if
you meant just the check_kernel_procs() function or that multiple functions
are affected by this issue.

I noticed that the preproc_build_firejail_dir_unlocked() function (and maybe
the other ones below) seem to also be affected:

• firejail/src/firejail/main.c

  Line 1170 in afce467

  preproc_build_firejail_dir_unlocked();

• firejail/src/firejail/main.c

  Line 1223 in afce467

  drop_privs(1);

• firejail/src/firejail/main.c

  Line 1335 in afce467

  if (checkcfg(CFG_FORCE_NONEWPRIVS))

In which case the current version of the message should be accurate, but if
that's not the case, the message could be simplified to:

The `arg_debug` flag is being set after the `check_kernel_procs()` function
checks for it.

Anyway, sorry for the confusion.

[powerjungle]

I see that you reworded the commit message (and undid it).

It was by accident, I didn't notice that you force pushed and I tried to fix the message later.

I was trying to improve the grammar with my force-push, but now I'm not sure if
you meant just the check_kernel_procs() function or that multiple functions
are affected by this issue.

I just gave it as an example, but yes there are more functions.

In which case the current version of the message should be accurate

I think the current version is fine.

Anyway, sorry for the confusion.

Sorry for the confusion too, I rushed through writing the message and I didn't notice how unclear and full with mistakes it was. 😅

I will get to the review a bit later today.