profiles: youtube-viewers: refactor and add gtk-youtube-viewers-common #5722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmk3
requested changes
Mar 9, 2023
kmk3
requested changes
Mar 9, 2023
kmk3
reviewed
Apr 11, 2023
There was a problem hiding this comment.
Please do the following:
Rebase to master (to integrate #5763):
git fetch
git checkout youtube-viewers
git rebase origin/master
git push --force-with-leaseNote: Make sure to do the above force-push separately so that the diffs of
later force-pushes are understandable.
Then:
- Do the changes from the review
- Squash all commits
- Change the commit title to the PR title
- Force-push
Other than that, LGTM.
kmk3
reviewed
Apr 15, 2023
There was a problem hiding this comment.
Note: These are still pending:
- Do the changes from the review
- Change the commit title to the PR title
kmk3
reviewed
Apr 15, 2023
kmk3
approved these changes
Apr 15, 2023
|
Merged, thanks! |
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Apr 19, 2023
For consistency and to reduce confusion.
The toolkit has been renamed from "GTK+" to just "GTK" in 2019[1].
Note: This also fixes some adjacent typos.
Commands used to search and replace:
$ git grep -lz 'G[Tt][Kk]' -- etc | xargs -0 -I '{}' sh -c \
"printf '%s\n' \"\$(sed -E \
-e 's/G[Tt][Kk]\+?/GTK/g' \
-e 's/GTK-.\.0/GTK/g' \
-e 's/GTK base/GTK-base/g' \
-e 's/GTK-base /GTK-based /g' \
-e 's/Light weight/Lightweight/g' \
-e 's/client with GTK/client made with GTK/g' '{}')\" >'{}'"
Misc: I noticed this on netblue30#5722.
[1] https://mail.gnome.org/archives/gtk-devel-list/2019-February/msg00000.html
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Apr 19, 2023
For consistency and to reduce confusion.
The toolkit has been renamed from "GTK+" to just "GTK" in 2019[1].
Note: This also fixes some adjacent typos.
Commands used to search and replace:
$ git grep -lz 'G[Tt][Kk]' -- etc | xargs -0 -I '{}' sh -c \
"printf '%s\n' \"\$(sed -E \
-e 's/G[Tt][Kk]\+?/GTK/g' \
-e 's/GTK-.\.0/GTK/g' \
-e 's/GTK base/GTK-base/g' \
-e 's/GTK-base /GTK-based /g' \
-e 's/Light weight/Lightweight/g' \
-e 's/client with GTK/client made with GTK/g' '{}')\" >'{}'"
Misc: I noticed this on netblue30#5722.
[1] https://mail.gnome.org/archives/gtk-devel-list/2019-February/msg00000.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created gtk-youtube-viewers-common.profile moved some stuff to it
some clean up
They will be easier to manage.