Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: refactor file managers into file-manager-common #3365

Closed
wants to merge 19 commits into from
Closed

profiles: refactor file managers into file-manager-common #3365

wants to merge 19 commits into from

Conversation

glitsj16
Copy link
Collaborator

Thought it might be a good idea to bring some sanity in the file manager profiles. Some allow Python, some Perl, some need Lua and then there's the more important issue of what we want those applications to see or not, do we allow/deny D-Bus, sound, etc.

This will need some decisions I suppose. For now I've just tried to incorporate options we already had in some but not in others and assumed we want file managers to at least see everything under ${HOME}.

@glitsj16 glitsj16 added the WIP: DON'T MERGE A PR that is still being worked on label Apr 18, 2020
@rusty-snake
Copy link
Collaborator

The question is, what is the purpose of the file-manager profiles.

@glitsj16
Copy link
Collaborator Author

glitsj16 commented Apr 18, 2020

@rusty-snake Yep, that's the first thing we should tackle. As we do see issues on them it seems like people are in fact using them... I for one do not and IMO keeeping them creates more issues, false sense of security than they offer protection. Decisions, decisions :-)

@smitsohu
Copy link
Collaborator

smitsohu commented Apr 20, 2020

The question is, what is the purpose of the file-manager profiles.

In case of Dolphin, you end up with the thumbnailing process sandboxed, which is the main (only?) benefit in my opinion.

edit: to clarify, KDE file choosers launch their own thumbnailer process in Firejail, so this reasoning is not limited to Dolphin.

@glitsj16
Copy link
Collaborator Author

@smitsohu Thanks for clarifying the dolphin situation. I re-added it to firecfg.

@glitsj16 glitsj16 changed the title WIP: Streamline file manager profiles Streamline file manager profiles Apr 21, 2020
@glitsj16
Copy link
Collaborator Author

glitsj16 commented Apr 21, 2020

Had some git trouble and lost my original branch. Closing here and creating a new PR:

@glitsj16 glitsj16 closed this Apr 21, 2020
@kmk3 kmk3 changed the title Streamline file manager profiles profiles: refactor file managers into file-manager-common Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP: DON'T MERGE A PR that is still being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants