Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supertuxkart: cannot see controller without netlink #4605

Closed
jose1711 opened this issue Oct 14, 2021 · 7 comments
Closed

supertuxkart: cannot see controller without netlink #4605

jose1711 opened this issue Oct 14, 2021 · 7 comments

Comments

@jose1711
Copy link
Contributor

If I want to be able to configure/use my SN30pro+ controller (wired mode) in supertuxkart I need to add netlink to

protocol unix,inet,inet6,bluetooth

This is probably xpad driver specific issue.

@jose1711
Copy link
Contributor Author

FWIW the game also crashes on changing resolutions if netlink is not added to the list. Wonder if anyone else can confirm (ideally running a non-Arch distro).

@jose1711
Copy link
Contributor Author

Also it's not just about xbox360 controller, it also affects my SNES-like DPAD.

@netblue30
Copy link
Owner

Fixed, thanks!

@rusty-snake
Copy link
Collaborator

  • supertuxkart.profile still lacks protocol netlink
  • 39654d0 add a lot of duplicated code

@netblue30
Copy link
Owner

netblue30 commented Jan 22, 2022

Something went very very wrong there!

I added it to supertuxkart. Do you need it for any other games?

kmk3 added a commit that referenced this issue Jan 24, 2022
This reverts commit 39654d0.

This only manually removes the RELNOTES entry; the other parts were
already partially reverted by commit ac83117 ("netlink - fixing the
fix", 2022-01-22) and commit 7df85d5 ("netlink: revert man pages",
2022-01-22).
@kmk3
Copy link
Collaborator

kmk3 commented Jan 25, 2022

@netblue30 commented on Jan 22:

Something went very very wrong there!

Please consider using git revert to revert commits whenever feasible, as it
undoes every change at once and also makes it clear in the log that the
original commit was reverted.

For example, in this case, git revert 8b92ac3eb would have been a clean
revert.

And if there were multiple commits to be reverted, the one thing to keep in
mind is that they have to be reverted in the opposite (topological) order that
they were committed. For example, given the following commits:

$ git log -n 4 --oneline --graph
* C bar 3
* B bar 2
* A bar 1
* X foo

To revert commits A, B and C, one would do:

git revert C
git revert B
git revert A

I added it to supertuxkart.

Can this be closed then?

@rusty-snake
Copy link
Collaborator

Can this be closed then?

I think so.

kmk3 added a commit to kmk3/firejail that referenced this issue Mar 13, 2022
As mentioned by @rusty-snake[1].

This amends commit 39654d0 ("adding netlink to --protocol list
(netblue30#4605)", 2022-01-21).

See also commit 75073e0 ("man: mention that private-bin and
private-etc are cumulative", 2022-01-22) and issue netblue30#4078.

[1] https://github.com/netblue30/firejail/pull/5042/files#r825477891
@kmk3 kmk3 changed the title Unless netlink is added to protocol supertuxkart does not see my xbox360-compatible controller supertuxkart: cannot see controller without netlink Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants