Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gvisor.dev/gvisor commit #3179

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

jameshilliard
Copy link
Contributor

@jameshilliard jameshilliard commented Jan 14, 2025

Commit b8a429915ff1 was replaced with db3d49b921f9 in gvisor project.

Maybe fixes a missing dependency issue like this.

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

@mlsmaycon
Copy link
Collaborator

mlsmaycon commented Jan 14, 2025

@jameshilliard can you share a bit more about the issue you are facing? Mainly, our workflows are building fine with the current version, so we are struggling to see where this is causing any failures.

On another note, we have a new feature coming up that will depend more on this package: https://github.com/netbirdio/netbird/pull/3134/files

@jameshilliard
Copy link
Contributor Author

can you share a bit more about the issue you are facing?

I'm hitting this error with GOPROXY=direct:

go: gvisor.dev/gvisor@v0.0.0-20231020174304-b8a429915ff1: invalid version: unknown revision b8a429915ff1

@jameshilliard jameshilliard force-pushed the update-gvisor branch 9 times, most recently from da430ae to a457502 Compare January 14, 2025 14:40
Commit b8a429915ff1 was replaced with db3d49b921f9 in gvisor project.
@jameshilliard jameshilliard changed the title Update gvisor.dev/gvisor Fix gvisor.dev/gvisor commit Jan 14, 2025
@jameshilliard
Copy link
Contributor Author

Looks like the failure was due to gvisor editing git history and replacing b8a429915ff1(which no longer belongs to the repository) with db3d49b921f9. I updated this PR to simply update the commit being referenced to the new valid version.

@mlsmaycon
Copy link
Collaborator

@lixmal do you see any issue with accepting this one and the Pr https://github.com/netbirdio/netbird/pull/3134/files?

@lixmal
Copy link
Contributor

lixmal commented Jan 15, 2025

Shouldn't be an issue

@mlsmaycon
Copy link
Collaborator

@jameshilliard thanks for the PR.

@mlsmaycon mlsmaycon merged commit 516de93 into netbirdio:main Jan 15, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants