-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gvisor.dev/gvisor commit #3179
Conversation
@jameshilliard can you share a bit more about the issue you are facing? Mainly, our workflows are building fine with the current version, so we are struggling to see where this is causing any failures. On another note, we have a new feature coming up that will depend more on this package: https://github.com/netbirdio/netbird/pull/3134/files |
I'm hitting this error with
|
da430ae
to
a457502
Compare
Commit b8a429915ff1 was replaced with db3d49b921f9 in gvisor project.
a457502
to
b235fe6
Compare
Quality Gate passedIssues Measures |
Looks like the failure was due to gvisor editing git history and replacing b8a429915ff1(which no longer belongs to the repository) with db3d49b921f9. I updated this PR to simply update the commit being referenced to the new valid version. |
@lixmal do you see any issue with accepting this one and the Pr https://github.com/netbirdio/netbird/pull/3134/files? |
Shouldn't be an issue |
@jameshilliard thanks for the PR. |
Commit b8a429915ff1 was replaced with db3d49b921f9 in gvisor project.
Maybe fixes a missing dependency issue like this.