Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go to 1.23 in devcontainer #3160

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

si458
Copy link
Contributor

@si458 si458 commented Jan 8, 2025

Describe your changes

this upgrades golang to 1.23 inside the devcontainer,
currently it wont build a devcontainer with 1.21 because a package requires 1.23 or above

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

sonarqubecloud bot commented Jan 8, 2025

@lixmal lixmal merged commit 9e6e34b into netbirdio:main Jan 8, 2025
4 checks passed
@si458 si458 deleted the upgrade-go branch January 8, 2025 10:48
@lixmal
Copy link
Contributor

lixmal commented Jan 8, 2025

Thanks for the contribution @si458

@si458
Copy link
Contributor Author

si458 commented Jan 8, 2025

@lixmal sure no worries!
only discovered this as i was trying to build the docker-compose to play around with netbird
but didnt want to build on my machine so i let vscode use the devcontainer instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants