[client] Add NB_SKIP_SOCKET_MARK & fix crash instead of returing an error #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure what is it with failing tests, doesn't seem like failures are related to my changes. |
lixmal
requested changes
Nov 19, 2024
util/net/net_linux.go
Outdated
| } | ||
|
|
||
| // Check for the new environment variable | ||
| if skipSocketMark := os.Getenv(envSkipSocketMark); skipSocketMark == "true" { |
There was a problem hiding this comment.
I suggest we add the env check here as well
This way we will fallback to exclusion routes automatically (instead of using fwmarks), to avoid routing loops.
There was a problem hiding this comment.
do you mean NB_SKIP_SOCKET_MARK=true should automatically imply NB_USE_LEGACY_ROUTING=true?
1478e01 to
c9f9533
Compare
c9f9533 to
bfa4772
Compare
Can you merge main? There's been an issue with a domain for the tests |
lixmal
reviewed
Nov 19, 2024
9c41d2a to
634596a
Compare
found during investigation of netbirdio#2530
fix created during investigation of netbirdio#2530
634596a to
4ed0d72
Compare
|
|
Thanks a lot |
lixmal
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I found some changes laying around on my computer when asked about #2530 (debugging my mobile router), can as well upstream those:
SO_MARKwithout disabling other custom routing featureslog.FatalfIssue ticket number and link
#2530
Checklist