Process routes before peers #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42e9061 to
9b30776
Compare
ed1533f to
562e398
Compare
29918dd to
941681e
Compare
c9e0d6a to
fd41cb9
Compare
fd41cb9 to
4a4677c
Compare
|
pappz
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We need to discard candidates thare are routed through any of our received routes (minus default route).
The existing approach to discard candidates when received in
onCandidatedoesn't catchprflxones.Hence we block candidates directly in the muxerconn's
WriteTomethod.Additonally this PR ensures we have routes present before deciding to discard ICE candidates that might be routed to other peers.
Issue ticket number and link
Checklist