Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect env for debug and routes sub commands #2026

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented May 21, 2024

Describe your changes

Issue ticket number and link

Updates #2013

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link
Collaborator

@mlsmaycon mlsmaycon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the change to the netbird status command too.

@lixmal
Copy link
Contributor Author

lixmal commented May 27, 2024

Please add the change to the netbird status command too.

That should already be the case:

func statusFunc(cmd *cobra.Command, args []string) error {
	SetFlagsFromEnvVars(rootCmd)

nazarewk added a commit to nazarewk-iac/nix-configs that referenced this pull request May 28, 2024
see netbirdio/netbird#2026

Signed-off-by: Krzysztof Nazarewski <gpg@kdn.im>
@nazarewk
Copy link
Contributor

FYI: works flawlessly with nazarewk-iac/nix-configs@a851563

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mlsmaycon mlsmaycon merged commit deffe03 into main Jun 6, 2024
24 checks passed
@mlsmaycon mlsmaycon deleted the fix/respect-env branch June 6, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants