Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limited dashboard view #1738

Merged
merged 11 commits into from
Mar 27, 2024
Merged

Add limited dashboard view #1738

merged 11 commits into from
Mar 27, 2024

Conversation

pascal-fischer
Copy link
Contributor

@pascal-fischer pascal-fischer commented Mar 21, 2024

Describe your changes

This PR adds a new settings field regular_users_view_blocked. Is this field is set to true it will the peer responses for regular users (admins and owners still have full response). Additionally it will extend the api response when querying for users with a permissions object that includes the dashboard_view. This will help the dashboard on what to show for each user until we have a full permissions functionality throughout the project.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

lixmal
lixmal previously approved these changes Mar 21, 2024
@braginini braginini dismissed lixmal’s stale review March 22, 2024 14:10

missing tests and setup keys and group endpoints return results

@braginini braginini self-requested a review March 27, 2024 15:11
@braginini braginini merged commit ea2d060 into main Mar 27, 2024
16 checks passed
@braginini braginini deleted the feature/limited-dashboard-view branch March 27, 2024 15:11
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants