Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --service/-s flag for specifying system service name #1691

Merged
merged 1 commit into from
Mar 12, 2024
Merged

add --service/-s flag for specifying system service name #1691

merged 1 commit into from
Mar 12, 2024

Conversation

nazarewk
Copy link
Contributor

@nazarewk nazarewk commented Mar 11, 2024 •
edited
Loading

Describe your changes

allows telling CLI what is the service name to control (for multi-instance deployments)

Issue ticket number and link

separated out of #1586

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@nazarewk nazarewk mentioned this pull request Mar 11, 2024
Merged
6 tasks
@nazarewk nazarewk marked this pull request as ready for review March 12, 2024 08:28
mlsmaycon
mlsmaycon approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@mlsmaycon mlsmaycon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @nazarewk

@mlsmaycon mlsmaycon merged commit ba33572 into netbirdio:main Mar 12, 2024
16 checks passed
@nazarewk nazarewk deleted the service-name-flag branch March 12, 2024 17:46
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
@nazarewk
add --service/-s flag for specifying system service name (netbirdio#1691
cab57cc 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsmaycon mlsmaycon mlsmaycon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nazarewk @mlsmaycon