Add context to throughout the project and update logging #5589
golangci-lint.yml
on: pull_request
codespell
11s
Matrix: lint
Annotations
30 errors and 4 warnings
|
lint (macos-latest):
management/server/mock_server/account_mock.go#L1
: # github.com/netbirdio/netbird/management/server/mock_server
|
|
lint (macos-latest):
management/server/mock_server/account_mock.go#L108
not enough return values
|
|
lint (macos-latest):
management/server/mock_server/account_mock.go#L290
not enough return values
|
|
lint (macos-latest):
management/server/mock_server/account_mock.go#L644
not enough return values
|
|
lint (macos-latest):
management/server/mock_server/account_mock.go#L652
not enough return values
|
|
lint (macos-latest):
client/cmd/debug.go#L1
: # github.com/netbirdio/netbird/client/cmd [github.com/netbirdio/netbird/client/cmd.test]
|
|
lint (macos-latest):
client/cmd/testutil_test.go#L90
not enough arguments in call to integrations.NewIntegratedValidator
|
|
lint (macos-latest):
client/internal/config.go#L1
: # github.com/netbirdio/netbird/client/internal [github.com/netbirdio/netbird/client/internal.test]
|
|
lint (macos-latest):
client/internal/engine_test.go#L1071
not enough arguments in call to integrations.NewIntegratedValidator
|
|
lint (macos-latest):
client/server/debug.go#L1
: # github.com/netbirdio/netbird/client/server [github.com/netbirdio/netbird/client/server.test]
|
|
lint (ubuntu-latest):
management/server/mock_server/account_mock.go#L1
: # github.com/netbirdio/netbird/management/server/mock_server
|
|
lint (ubuntu-latest):
management/server/mock_server/account_mock.go#L108
not enough return values
|
|
lint (ubuntu-latest):
management/server/mock_server/account_mock.go#L290
not enough return values
|
|
lint (ubuntu-latest):
management/server/mock_server/account_mock.go#L644
not enough return values
|
|
lint (ubuntu-latest):
management/server/mock_server/account_mock.go#L652
not enough return values
|
|
lint (ubuntu-latest):
client/cmd/debug.go#L1
: # github.com/netbirdio/netbird/client/cmd [github.com/netbirdio/netbird/client/cmd.test]
|
|
lint (ubuntu-latest):
client/cmd/testutil_test.go#L90
not enough arguments in call to integrations.NewIntegratedValidator
|
|
lint (ubuntu-latest):
client/internal/config.go#L1
: # github.com/netbirdio/netbird/client/internal [github.com/netbirdio/netbird/client/internal.test]
|
|
lint (ubuntu-latest):
client/internal/engine_test.go#L1071
not enough arguments in call to integrations.NewIntegratedValidator
|
|
lint (ubuntu-latest):
client/server/debug.go#L1
: # github.com/netbirdio/netbird/client/server [github.com/netbirdio/netbird/client/server.test]
|
|
lint (windows-latest)
not enough return values\n\thave (*\"github.com/netbirdio/netbird/management/server/peer\".Peer, *server.NetworkMap, error)\n\twant (*\"github.com/netbirdio/netbird/management/server/peer\".Peer, *server.NetworkMap, []*posture.Checks, error)"
|
|
lint (windows-latest)
not enough arguments in call to integrations.NewIntegratedValidator\n\thave (*activity.InMemoryEventStore)\n\twant (\"context\".Context, activity.Store)"
|
|
lint (windows-latest)
not enough arguments in call to integrations.NewIntegratedValidator\n\thave (*activity.InMemoryEventStore)\n\twant (\"context\".Context, activity.Store)"
|
|
lint (windows-latest)
not enough arguments in call to integrations.NewIntegratedValidator\n\thave (*activity.InMemoryEventStore)\n\twant (\"context\".Context, activity.Store)"
|
|
lint (windows-latest)
not enough return values\n\thave (*\"github.com/netbirdio/netbird/management/server/peer\".Peer, *server.NetworkMap, error)\n\twant (*\"github.com/netbirdio/netbird/management/server/peer\".Peer, *server.NetworkMap, []*posture.Checks, error))"
|
|
lint (windows-latest)
not enough arguments in call to integrations.NewIntegratedValidator\n\thave (*activity.InMemoryEventStore)\n\twant (\"context\".Context, activity.Store)"
|
|
lint (windows-latest)
cannot use MocIntegratedValidator{} (value of type MocIntegratedValidator) as integrated_validator.IntegratedValidator value in struct literal: MocIntegratedValidator does not implement integrated_validator.IntegratedValidator (wrong type for method IsNotValidPeer)\n\t\thave IsNotValidPeer(string, *\"github.com/netbirdio/netbird/management/server/peer\".Peer, []string, *account.ExtraSettings) (bool, bool, error)\n\t\twant IsNotValidPeer(\"context\".Context, string, *\"github.com/netbirdio/netbird/management/server/peer\".Peer, []string, *account.ExtraSettings) (bool, bool, error)"
|
|
lint (windows-latest)
cannot use MocIntegratedValidator{} (value of type MocIntegratedValidator) as integrated_validator.IntegratedValidator value in struct literal: MocIntegratedValidator does not implement integrated_validator.IntegratedValidator (wrong type for method IsNotValidPeer)\n\t\thave IsNotValidPeer(string, *\"github.com/netbirdio/netbird/management/server/peer\".Peer, []string, *account.ExtraSettings) (bool, bool, error)\n\t\twant IsNotValidPeer(\"context\".Context, string, *\"github.com/netbirdio/netbird/management/server/peer\".Peer, []string, *account.ExtraSettings) (bool, bool, error))"
|
|
lint (windows-latest)
not enough return values\n\thave (*\"github.com/netbirdio/netbird/management/server/peer\".Peer, *server.NetworkMap, error)\n\twant (*\"github.com/netbirdio/netbird/management/server/peer\".Peer, *server.NetworkMap, []*posture.Checks, error))"
|
|
lint (windows-latest)
golangci-lint exit with code 7
|
|
codespell
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint (macos-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint (windows-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|