chore: upgrade eslint, update husky config

nestjs · Jan 17, 2025 · 2c011fa · 2c011fa
1 parent 4134457
commit 2c011fa
Show file tree

Hide file tree

Showing 11 changed files with 264 additions and 2,513 deletions.
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintrc.js b/.eslintrc.js
diff --git a/.husky/commit-msg b/.husky/commit-msg
@@ -1,4 +1 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
 npx --no-install commitlint --edit $1
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -1,4 +1 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
 npx --no-install lint-staged
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,41 @@
+// @ts-check
+import eslint from '@eslint/js';
+import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended';
+import globals from 'globals';
+import tseslint from 'typescript-eslint';
+
+export default tseslint.config(
+  {
+    ignores: ['tests/**'],
+  },
+  eslint.configs.recommended,
+  ...tseslint.configs.recommendedTypeChecked,
+  eslintPluginPrettierRecommended,
+  {
+    languageOptions: {
+      globals: {
+        ...globals.node,
+        ...globals.jest,
+      },
+      ecmaVersion: 5,
+      sourceType: 'module',
+      parserOptions: {
+        projectService: true,
+        tsconfigRootDir: import.meta.dirname,
+      },
+    },
+  },
+  {
+    rules: {
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-unsafe-assignment': 'off',
+      '@typescript-eslint/no-unsafe-call': 'off',
+      '@typescript-eslint/no-unsafe-member-access': 'off',
+      '@typescript-eslint/no-unsafe-function-type': 'off',
+      '@typescript-eslint/no-unsafe-argument': 'off',
+      '@typescript-eslint/no-unsafe-return': 'off',
+      '@typescript-eslint/require-await': 'warn',
+      '@typescript-eslint/no-misused-promises': 'warn',
+    },
+  },
+);
diff --git a/lib/common/typeorm.utils.ts b/lib/common/typeorm.utils.ts
@@ -78,12 +78,12 @@ export function getDataSourceToken(
     | string = DEFAULT_DATA_SOURCE_NAME,
 ): string | Function | Type<DataSource> {
   return DEFAULT_DATA_SOURCE_NAME === dataSource
-    ? DataSource ?? Connection
+    ? (DataSource ?? Connection)
     : 'string' === typeof dataSource
-    ? `${dataSource}DataSource`
-    : DEFAULT_DATA_SOURCE_NAME === dataSource.name || !dataSource.name
-    ? DataSource ?? Connection
-    : `${dataSource.name}DataSource`;
+      ? `${dataSource}DataSource`
+      : DEFAULT_DATA_SOURCE_NAME === dataSource.name || !dataSource.name
+        ? (DataSource ?? Connection)
+        : `${dataSource.name}DataSource`;
 }
 
 /** @deprecated */
@@ -128,10 +128,10 @@ export function getEntityManagerToken(
   return DEFAULT_DATA_SOURCE_NAME === dataSource
     ? EntityManager
     : 'string' === typeof dataSource
-    ? `${dataSource}EntityManager`
-    : DEFAULT_DATA_SOURCE_NAME === dataSource.name || !dataSource.name
-    ? EntityManager
-    : `${dataSource.name}EntityManager`;
+      ? `${dataSource}EntityManager`
+      : DEFAULT_DATA_SOURCE_NAME === dataSource.name || !dataSource.name
+        ? EntityManager
+        : `${dataSource.name}EntityManager`;
 }
 
 export function handleRetry(

diff --git a/lib/entities-metadata.storage.ts b/lib/entities-metadata.storage.ts
@@ -22,10 +22,10 @@ export class EntitiesMetadataStorage {
       this.storage.set(dataSourceToken, collection);
     }
     entities.forEach((entity) => {
-      if (collection!.includes(entity)) {
+      if (collection.includes(entity)) {
         return;
       }
-      collection!.push(entity);
+      collection.push(entity);
     });
   }
 

diff --git a/lib/typeorm-core.module.ts b/lib/typeorm-core.module.ts
@@ -234,7 +234,9 @@ export class TypeOrmCoreModule implements OnApplicationShutdown {
           } as DataSourceOptions);
         }
         // TODO: remove "dataSource.initialize" condition (left for backward compatibility)
-        return (dataSource as any).initialize && !dataSource.isInitialized && !options.manualInitialization
+        return (dataSource as any).initialize &&
+          !dataSource.isInitialized &&
+          !options.manualInitialization
           ? dataSource.initialize()
           : dataSource;
       }).pipe(

diff --git a/lib/typeorm.providers.ts b/lib/typeorm.providers.ts
@@ -10,9 +10,11 @@ export function createTypeOrmProviders(
   return (entities || []).map((entity) => ({
     provide: getRepositoryToken(entity, dataSource),
     useFactory: (dataSource: DataSource) => {
-      const entityMetadata = dataSource.entityMetadatas.find((meta) => meta.target === entity)
-      const isTreeEntity = typeof entityMetadata?.treeType !== 'undefined'
-      return isTreeEntity 
+      const entityMetadata = dataSource.entityMetadatas.find(
+        (meta) => meta.target === entity,
+      );
+      const isTreeEntity = typeof entityMetadata?.treeType !== 'undefined';
+      return isTreeEntity
         ? dataSource.getTreeRepository(entity)
         : dataSource.options.type === 'mongodb'
           ? dataSource.getMongoRepository(entity)