Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(@nestjs/terminus) Add health check for mongoose ODM #37

Merged
merged 3 commits into from
Jan 8, 2019

Conversation

nartc
Copy link

@nartc nartc commented Jan 8, 2019

  • Refactor for HealthIndicator and AbstractDatabaseHealthIndicator abstract classes
  • Make MongooseHealtIndicator and DatabaseHealthIndicator (subject to rename to TypeOrm) to extends AbstractDatabaseHealthIndicator for abstract pingDb and the underlying connection
  • Add mongoose and @nestjs/mongoose to peerDependencies and optionalDependencies
  • Add @types/mongoose to devDependencies
  • Add Unit Test (With Livio help. Thanks!)
  • Add new sample app 001-mongoose-app to demo MongooseHealthIndicator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #35

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Chau added 3 commits January 7, 2019 21:53
- Refactor for `HealthIndicator` and `AbstractDatabaseHealthIndicator` abstract classes
- Make `MongooseHealtIndicator` and `DatabaseHealthIndicator` (**subject to rename to TypeOrm**) to extends `AbstractDatabaseHealthIndicator` for `abstract pingDb` and the underlying `connection`
- Add `mongoose` and `@nestjs/mongoose` to peerDependencies and optionalDependencies
- Add `@types/mongoose` to devDependencies
- Add Unit Test (With Livio help. Thanks!)
- Add new sample app `001-mongoose-app` to demo `MongooseHealthIndicator`
- Remove mongodb from services in Travis. I believe we're pulling in a mongo image in docker compose. Having mongodb as a Travis's service occupies port 27017.
@BrunnerLivio
Copy link
Member

Great! Thanks a lot for your time, really clean PR :)

@BrunnerLivio BrunnerLivio merged commit 5ea8171 into nestjs:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants