Merge pull request #3171 from mattia-lau/fix/federation-interface-res…

…olver

fix(apollo): federation interface resolver

packages/apollo/tests/code-first-federation/app.module.ts

@@ -7,13 +7,16 @@ import { PostModule } from './post/post.module';
 import { RecipeModule } from './recipe/recipe.module';
 import { User } from './user/user.entity';
 import { UserModule } from './user/user.module';
+import { HumanModule } from './human/human.module';
 
 @Module({
   imports: [
     UserModule,
     PostModule,
     RecipeModule,
+    HumanModule,
     GraphQLModule.forRoot<ApolloDriverConfig>({
+      inheritResolversFromInterfaces: true,
       driver: ApolloFederationDriver,
       includeStacktraceInErrorResponses: false,
       autoSchemaFile: true,

packages/apollo/tests/code-first-federation/human/character.entity.ts

@@ -0,0 +1,10 @@
+import { Field, ID, InterfaceType } from '@nestjs/graphql';
+
+@InterfaceType()
+export abstract class Character {
+  @Field((type) => ID)
+  id: string;
+
+  @Field()
+  name: string;
+}

packages/apollo/tests/code-first-federation/human/human.entity.ts

@@ -0,0 +1,10 @@
+import { ObjectType } from '@nestjs/graphql';
+import { Character } from './character.entity';
+
+@ObjectType({
+  implements: () => [Character],
+})
+export class Human implements Character {
+  id: string;
+  name: string;
+}

packages/apollo/tests/code-first-federation/human/human.module.ts

@@ -0,0 +1,7 @@
+import { Module } from '@nestjs/common';
+import { HumanResolver } from './human.resolver';
+
+@Module({
+  providers: [HumanResolver],
+})
+export class HumanModule {}

packages/apollo/tests/code-first-federation/human/human.resolver.ts

@@ -0,0 +1,19 @@
+import { Query, Resolver, ResolveField } from '@nestjs/graphql';
+import { Human } from './human.entity';
+import { Character } from './character.entity';
+
+@Resolver(() => Character)
+export class HumanResolver {
+  @Query(() => [Human])
+  humans(): Human[] {
+    return [
+      { id: '1', name: 'Bob' },
+      { id: '2', name: 'Alice' },
+    ];
+  }
+
+  @ResolveField(() => [Human])
+  friends(): Human[] {
+    return [{ id: '3', name: 'Peter' }];
+  }
+}

packages/apollo/tests/e2e/__snapshots__/code-first-federation.spec.ts.snap

@@ -52,11 +52,24 @@ type Recipe implements IRecipe {
   description: String!
 }
 
+type Human implements Character {
+  id: ID!
+  name: String!
+  friends: [Human!]!
+}
+
+interface Character {
+  id: ID!
+  name: String!
+  friends: [Human!]!
+}
+
 type Query {
   findPost(id: Float!): Post!
   getPosts: [Post!]!
   search: [FederationSearchResultUnion!]! @deprecated(reason: "test")
   recipe: IRecipe!
+  humans: [Human!]!
   _entities(representations: [_Any!]!): [_Entity]!
   _service: _Service!
 }

packages/apollo/tests/e2e/code-first-federation.spec.ts

@@ -89,6 +89,37 @@ describe('Code-first - Federation', () => {
     });
   });
 
+  it('should return the human result with resolve interface', async () => {
+    const response = await apolloClient.executeOperation({
+      query: gql`
+        {
+          humans {
+            id
+            name
+            friends {
+              id
+              name
+            }
+          }
+        }
+      `,
+    });
+    expectSingleResult(response).toEqual({
+      humans: [
+        {
+          id: '1',
+          name: 'Bob',
+          friends: [{ id: '3', name: 'Peter' }],
+        },
+        {
+          id: '2',
+          name: 'Alice',
+          friends: [{ id: '3', name: 'Peter' }],
+        },
+      ],
+    });
+  });
+
   afterEach(async () => {
     await app.close();
   });

packages/graphql/lib/federation/graphql-federation.factory.ts

@@ -139,9 +139,15 @@ export class GraphQLFederationFactory {
       typeDefs = typeDefsDecorator.decorate(typeDefs, federationOptions);
     }
 
-    let executableSchema: GraphQLSchema = buildFederatedSchema({
-      typeDefs: gql(typeDefs),
-      resolvers: this.getResolvers(options.resolvers),
+    const resolvers = this.getResolvers(options.resolvers);
+    let executableSchema: GraphQLSchema = addResolversToSchema({
+      schema: buildFederatedSchema({
+        typeDefs: gql(typeDefs),
+        resolvers,
+      }),
+      resolvers,
+      resolverValidationOptions: options.resolverValidationOptions,
+      inheritResolversFromInterfaces: options.inheritResolversFromInterfaces,
     });
 
     executableSchema = this.overrideOrExtendResolvers(