Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade cookie from 0.6.0 to 1.0.1 #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nerdy-tech-com-gitub
Copy link
Owner

@nerdy-tech-com-gitub nerdy-tech-com-gitub commented Dec 6, 2024

snyk-top-banner

Snyk has created this PR to upgrade cookie from 0.6.0 to 1.0.1.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


⚠️ Warning: This PR contains major version upgrade(s), and may be a breaking change.

  • The recommended version is 5 versions ahead of your current version.

  • The recommended version was released on 2 months ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
medium severity Cross-site Scripting (XSS)
SNYK-JS-COOKIE-8163060
58 No Known Exploit
Release notes
Package name: cookie
  • 1.0.1 - 2024-10-11

    Added

    v1.0.0...v1.0.1

  • 1.0.0 - 2024-10-08

    Breaking changes

    • Use modern JS features, ship TypeScript definition (#175) 1cc64ff
      • Adds __esModule marker, imports need to use import { parse, serialize } or import * as cookie
    • Minimum node.js v18
    • Uses null prototype object for parse return value
    • Changes strict and priority to match the lower case strings (i.e. low, not LOW or Low)
    • Require maxAge to be an integer using Number.isInteger check
    • Delegates decode implementation details to decode option (i.e. error handling and quote parsing is defined by decode)
    • Improve arg/option error messages (#162) e206fd5 @ MaoShizhong

    Other

    v0.7.2...v1.0.0

  • 0.7.2 - 2024-10-07

    Fixed

    • Fix object assignment of hasOwnProperty (#177) bc38ffd

    v0.7.1...v0.7.2

  • 0.7.1 - 2024-10-03

    Fixed

    • Allow leading dot for domain (#174)
      • Although not permitted in the spec, some users expect this to work and user agents ignore the leading dot according to spec
    • Add fast path for serialize without options, use obj.hasOwnProperty when parsing (#172)

    v0.7.0...v0.7.1

  • 0.7.0 - 2024-10-02

    v0.6.0...v0.7.0

  • 0.6.0 - 2023-11-07
    • Add partitioned option
from cookie GitHub release notes

Important

  • Warning: This PR contains a major version upgrade, and may be a breaking change.
  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Summary by Sourcery

Upgrade the 'cookie' package from version 0.6.0 to 1.0.1 to address a cross-site scripting (XSS) vulnerability and introduce breaking changes with modern JavaScript features and TypeScript definitions.

Bug Fixes:

  • Fix cross-site scripting (XSS) vulnerability by upgrading the 'cookie' package.

Enhancements:

  • Upgrade 'cookie' package from version 0.6.0 to 1.0.1 to incorporate modern JavaScript features and TypeScript definitions.

Snyk has created this PR to upgrade cookie from 0.6.0 to 1.0.1.

See this package in npm:
cookie

See this project in Snyk:
https://app.snyk.io/org/nerds-github/project/68cffb67-4af2-4355-88e0-e2c7b70b6a1a?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

sourcery-ai bot commented Dec 6, 2024

Reviewer's Guide by Sourcery

This PR upgrades the cookie package from version 0.6.0 to 1.0.1 to address a medium severity Cross-site Scripting (XSS) vulnerability. The upgrade includes several breaking changes as it's a major version bump, including modernized JS features, TypeScript definitions, and changes to option handling.

Class diagram for updated cookie package

classDiagram
    class Cookie {
        +parse()
        +serialize()
        +__esModule
        +decode
        +maxAge: Integer
        +strict: String
        +priority: String
    }
    note for Cookie "Modern JS features and TypeScript definitions added"
    note for Cookie "Breaking changes in option handling and decode implementation"
Loading

File-Level Changes

Change Details Files
Dependency version upgrade with breaking changes
  • Updates cookie package from 0.6.0 to 1.0.1
  • Introduces TypeScript definitions and modern JS features
  • Changes import syntax to use named imports or namespace imports
  • Modifies option handling for 'strict' and 'priority' to use lowercase strings
  • Adds stricter validation for maxAge option requiring integer values
  • Changes decode implementation handling
docker/coolify-realtime/package.json
Security vulnerability fix
  • Addresses medium severity XSS vulnerability (SNYK-JS-COOKIE-8163060)
  • Improves security with a vulnerability score of 58/1000
docker/coolify-realtime/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants