-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snyk] Upgrade cookie from 0.6.0 to 1.0.1 #28
base: main
Are you sure you want to change the base?
[Snyk] Upgrade cookie from 0.6.0 to 1.0.1 #28
Conversation
Snyk has created this PR to upgrade cookie from 0.6.0 to 1.0.1. See this package in npm: cookie See this project in Snyk: https://app.snyk.io/org/nerds-github/project/68cffb67-4af2-4355-88e0-e2c7b70b6a1a?utm_source=github&utm_medium=referral&page=upgrade-pr
Reviewer's Guide by SourceryThis PR upgrades the cookie package from version 0.6.0 to 1.0.1 to address a medium severity Cross-site Scripting (XSS) vulnerability. The upgrade includes several breaking changes as it's a major version bump, including modernized JS features, TypeScript definitions, and changes to option handling. Class diagram for updated cookie packageclassDiagram
class Cookie {
+parse()
+serialize()
+__esModule
+decode
+maxAge: Integer
+strict: String
+priority: String
}
note for Cookie "Modern JS features and TypeScript definitions added"
note for Cookie "Breaking changes in option handling and decode implementation"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. Here's why:
- It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
- We don't review packaging changes - Let us know if you'd like us to change this.
Snyk has created this PR to upgrade cookie from 0.6.0 to 1.0.1.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 5 versions ahead of your current version.
The recommended version was released on 2 months ago.
Issues fixed by the recommended upgrade:
SNYK-JS-COOKIE-8163060
Release notes
Package name: cookie
Added
v1.0.0...v1.0.1
Breaking changes
__esModule
marker, imports need to useimport { parse, serialize }
orimport * as cookie
parse
return valuestrict
andpriority
to match the lower case strings (i.e.low
, notLOW
orLow
)maxAge
to be an integer usingNumber.isInteger
checkdecode
option (i.e. error handling and quote parsing is defined bydecode
)decode
(#180) c4a2597Other
hasOwnProperty
, useundefined
check for performance (#183) 8f3ee9e @ gurgundayv0.7.2...v1.0.0
Fixed
hasOwnProperty
(#177) bc38ffdv0.7.1...v0.7.2
Fixed
serialize
without options, useobj.hasOwnProperty
when parsing (#172)v0.7.0...v0.7.1
main
topackage.json
for rspack (#166 by @ proudparrot2)v0.6.0...v0.7.0
partitioned
optionImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
Summary by Sourcery
Upgrade the 'cookie' package from version 0.6.0 to 1.0.1 to address a cross-site scripting (XSS) vulnerability and introduce breaking changes with modern JavaScript features and TypeScript definitions.
Bug Fixes:
Enhancements: