Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add OpenShift GPU quota support #123

Merged
merged 1 commit into from
Nov 27, 2023
Merged

add OpenShift GPU quota support #123

merged 1 commit into from
Nov 27, 2023

Conversation

jtriley
Copy link
Contributor

@jtriley jtriley commented Nov 9, 2023

closes #111

@jtriley jtriley requested a review from knikolla November 9, 2023 19:36
@jtriley jtriley mentioned this pull request Nov 9, 2023
Closed
@jtriley
Copy link
Contributor Author

jtriley commented Nov 9, 2023

The test-py39-functional-microshift test is failing currently due to 500 internal error. Not sure that's related to this PR - seems like maybe a transient issue with the github actions runners?

@knikolla
Copy link
Collaborator

knikolla commented Nov 9, 2023

The test-py39-functional-microshift test is failing currently due to 500 internal error. Not sure that's related to this PR - seems like maybe a transient issue with the github actions runners?

That test has become a bit flakier lately, I re-ran the job. If this starts affecting us more severely we should allocating some time to investigate.

@jtriley jtriley force-pushed the openshift-gpu-quotas branch from f7db726 to 84e4ef7 Compare November 11, 2023 20:29
@jtriley
Copy link
Contributor Author

jtriley commented Nov 15, 2023 •
edited
Loading

Re-running the failed job(s) doesn't seem to be working anymore. I'm debugging the CI/CD issue with microshift on a test VM currently.

@knikolla
Copy link
Collaborator

Re-running the failed job(s) doesn't seem to be working anymore. I'm debugging the CI/CD issue with microshift on a test VM currently.

Yes, I created an issue and will be investigating today. #124

@jtriley jtriley marked this pull request as ready for review November 15, 2023 18:26
@jtriley jtriley merged commit 3ac55af into main Nov 27, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knikolla knikolla knikolla left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the attributes needed in OpenShift i.e. nvidia.com/gpu specifically for RHODS to use GPU resource
2 participants
@jtriley @knikolla