Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if linting works on clean PR #722

Closed
wants to merge 6 commits into from

Conversation

liamfallon
Copy link
Member

Linting is failing on #597, this PR is a test PR to see if linting is working on the main branch with just a linter upgrade.

@nephio-prow nephio-prow bot requested review from efiacor and johnbelamaric April 25, 2024 08:01
Copy link
Contributor

nephio-prow bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from liamfallon by writing /assign @liamfallon in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liamfallon
Copy link
Member Author

/retest

nephio-prow bot pushed a commit that referenced this pull request Apr 27, 2024
golangci-lint update to work with go 1.22 updated other components as
well
This resolves failing tests in
#597 and
#722
@liamfallon
Copy link
Member Author

All linting and security checks are now passing.

@liamfallon liamfallon closed this Apr 28, 2024
@liamfallon liamfallon deleted the check-linting branch April 28, 2024 10:37
PrimalPimmy pushed a commit to 5GSEC/nephio that referenced this pull request Aug 2, 2024
golangci-lint update to work with go 1.22 updated other components as
well
This resolves failing tests in
nephio-project#597 and
nephio-project#722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant