-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert inadvertent check in of file to documentation #93
Revert inadvertent check in of file to documentation #93
Conversation
/assign @tliron |
Good catch. |
Can you add a bit more descriptive name to the pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @liamfallon |
I've just learned from @kispaljr that mockery is still used but I could not find the referred file even in the history ( All in all it is ok to delete the file. |
Well it was my error that it was included. Yes Mockery is being used but I checked in a preliminary version of Mockery instructions that I'm working on. It's not ready to be merged yet. |
Done |
I will add the Mockery description in a few days when I get a chance to add/edit the text properly. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CsatariGergely, efiacor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The developer guide has already been moved to to content/en/docs/guides/contributor-guides. It was inadvertently added in PR-92 and should be deleted here.