Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usecase guide for Centralized FluxCD deployment #203

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

efiacor
Copy link
Collaborator

@efiacor efiacor commented Feb 7, 2025

New guides for deploying and using the FluxCD controllers

Also, refactored the user guides section to separate the logic into:

  • Usecases
  • Controllers & Operators
  • Other...

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit d6c7f1f
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/67a7ba5dae77390008f23148
😎 Deploy Preview https://deploy-preview-203--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@efiacor efiacor requested a review from nagygergo February 10, 2025 08:37
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@nephio-prow nephio-prow bot added the approved label Feb 10, 2025
@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit 4088784 into nephio-project:main Feb 13, 2025
8 checks passed
@@ -14,6 +14,7 @@ ignorePatterns:
- pattern: "https://\\*kpt\\*\\.dev/"
- pattern: "https://my-gitlab\\.com/joe\\.bloggs/blueprints\\.git"
- pattern: "http://172\\.18\\.0\\.200:3000/nephio/"
- pattern: "https://www\\.gnu\\.org/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the problem with gnu.org?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started timing out recently for some reason. Link is fine but linkinspector was failing with false negative.
https://github.com/nephio-project/docs/actions/workflows/check-links-md.yml


## FluxCD Controllers

As an alternative Git-ops tool running on the Nephio mgmt cluster,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As an alternative Git-ops tool running on the Nephio mgmt cluster,
As an alternative Git-ops tool running on the Nephio management cluster,

kpt live apply fluxcd --reconcile-timeout=15m --output=table
```

The controllers are deployed to the `flux-system` namespace by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The controllers are deployed to the `flux-system` namespace by default.
The controllers are deployed to the *flux-system* namespace by default.

{{% /alert %}}

First, verify that the [catalog blueprint repositories](https://github.com/nephio-project/catalog.git) are registered
and `Ready`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
and `Ready`:
and *Ready*:

oai-core-packages git Package false True https://github.com/OPENAIRINTERFACE/oai-packages.git
```

Once `Ready`, we can utilize blueprint packages from these upstream repositories.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once `Ready`, we can utilize blueprint packages from these upstream repositories.
Once *Ready*, we can utilize blueprint packages from these upstream repositories.

{{% alert title="Note" color="primary" %}}

Due to the extensive use of `local-config` in the current[Nephio Workload packages](https://github.com/nephio-project/catalog/tree/main/workloads),
plus the target `spec.path` of **root** defined in the Flux Kustomization CR used,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
plus the target `spec.path` of **root** defined in the Flux Kustomization CR used,
plus the target *spec.path* of **root** defined in the Flux Kustomization CR used,


Due to the extensive use of `local-config` in the current[Nephio Workload packages](https://github.com/nephio-project/catalog/tree/main/workloads),
plus the target `spec.path` of **root** defined in the Flux Kustomization CR used,
we require a workaround to generate a `kustomization.yaml` at the root of each kpt pkg deployed to the same downstream Repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
we require a workaround to generate a `kustomization.yaml` at the root of each kpt pkg deployed to the same downstream Repository.
we require a workaround to generate a *kustomization.yaml* at the root of each kpt pkg deployed to the same downstream Repository.

Due to the extensive use of `local-config` in the current[Nephio Workload packages](https://github.com/nephio-project/catalog/tree/main/workloads),
plus the target `spec.path` of **root** defined in the Flux Kustomization CR used,
we require a workaround to generate a `kustomization.yaml` at the root of each kpt pkg deployed to the same downstream Repository.
In the example above, this is done via a `PackageVariant.spec.pipeline.mutators` [kpt function](https://github.com/nephio-project/nephio/blob/main/krm-functions/gen-kustomize-res/README.md),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the example above, this is done via a `PackageVariant.spec.pipeline.mutators` [kpt function](https://github.com/nephio-project/nephio/blob/main/krm-functions/gen-kustomize-res/README.md),
In the example above, this is done via a *PackageVariant.spec.pipeline.mutators* [kpt function](https://github.com/nephio-project/nephio/blob/main/krm-functions/gen-kustomize-res/README.md),


{{% /alert %}}

Once the Porch and Nephio controllers have completed their tasks, the mutated `spec.upstream.package` resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once the Porch and Nephio controllers have completed their tasks, the mutated `spec.upstream.package` resources
Once the Porch and Nephio controllers have completed their tasks, the mutated *spec.upstream.package* resources

{{% /alert %}}

Once the Porch and Nephio controllers have completed their tasks, the mutated `spec.upstream.package` resources
are pushed to the `spec.downstream.repo` git repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
are pushed to the `spec.downstream.repo` git repository.
are pushed to the *spec.downstream.repo* git repository.

@efiacor efiacor deleted the add_central_fluxcd_docs branch February 13, 2025 16:24
@liamfallon
Copy link
Member

@efiacor can we address the comments of @CsatariGergely and raise a new PR if needed?

efiacor added a commit to Nordix/nephio-docs that referenced this pull request Feb 13, 2025
@efiacor
Copy link
Collaborator Author

efiacor commented Feb 13, 2025

All comments addressed in #207

JamesMcDermott pushed a commit to Nordix/nephio-docs that referenced this pull request Feb 18, 2025
New guides for deploying and using the FluxCD controllers

Also, refactored the user guides section to separate the logic into:
- Usecases
- Controllers & Operators
- Other...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants