Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language corrections for the R3 Release Notes. #175

Merged

Conversation

mpgreaves
Copy link
Contributor

No description provided.

Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
@nephio-prow nephio-prow bot requested review from CsatariGergely and s3wong October 3, 2024 07:54
Copy link
Contributor

nephio-prow bot commented Oct 3, 2024

Hi @mpgreaves. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 9b440fe
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/67234cddfd2c0500088b586c
😎 Deploy Preview https://deploy-preview-175--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CsatariGergely
Copy link
Contributor

/assign @liamfallon @ciaranjohnston

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@nephio-prow nephio-prow bot added the approved label Oct 4, 2024
@liamfallon
Copy link
Member

/ok-to-test

@liamfallon
Copy link
Member

/retest

2 similar comments
@liamfallon
Copy link
Member

/retest

@liamfallon
Copy link
Member

/retest

@arora-sagar
Copy link
Contributor

Hi @mpgreaves can you address the comments of the github runner? There are couple of tiny adjustments

Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
@mpgreaves
Copy link
Contributor Author

@arora-sagar, I have implemented the comments that are valid.

@liamfallon
Copy link
Member

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Nov 4, 2024
Copy link
Contributor

nephio-prow bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit 7f04cc1 into nephio-project:main Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants