Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging changes from old R3 branch to newly created #157

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Conversation

radoslawc
Copy link
Contributor

No description provided.

Fixing the 404 issue of the breadcrumb navigation in R3.

/assign @efiacor @liamfallon 

This supposed to fix the issue for the R3 branch pointed out by @efiacor
in
#128 (review)

As an extra I'm adding the link fixes to R3 merged to main in
#130
(69c79e2)

Link checks for the [LFN Wiki](https://wiki.lfnetworking.org/) are
disabled as the wiki is down. [LF IT
ticket](https://jira.linuxfoundation.org/plugins/servlet/desk/portal/2/IT-26874)
was created.

---------

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Partially fixes: nephio-project/nephio#738

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for nephio-r3 ready!

Name Link
🔨 Latest commit 6c25643
🔍 Latest deploy log https://app.netlify.com/sites/nephio-r3/deploys/669fb1d17901670008893877
😎 Deploy Preview https://deploy-preview-157--nephio-r3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@radoslawc radoslawc marked this pull request as draft July 23, 2024 10:49
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
/approve

@nephio-prow nephio-prow bot added the approved label Jul 23, 2024
@radoslawc radoslawc marked this pull request as ready for review July 23, 2024 12:28
@nephio-prow nephio-prow bot requested review from henderiw and liamfallon July 23, 2024 12:28
Copy link
Contributor

nephio-prow bot commented Jul 23, 2024

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@arora-sagar
Copy link
Contributor

/lgtm

@nephio-prow nephio-prow bot merged commit 33d4ab1 into R3 Jul 23, 2024
8 checks passed
@radoslawc radoslawc deleted the R3_back branch July 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants