Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Porch documentation to the docs.nephio.org #144

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

CsatariGergely
Copy link
Contributor

This pr adds the markdown documentation of Porch to docs.nephio.org .
Open issues are collected in here.

Fixes nephio-project/nephio#744

Aadded files were copied from the Porch repository.

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit bf35733
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/6687d9e3167bf600081dfa6f
😎 Deploy Preview https://deploy-preview-144--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @CsatariGergely , just some small wording comments.

Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>
@CsatariGergely
Copy link
Contributor Author

@liamfallon thanks for the suggestions, I've applied them.

@liamfallon
Copy link
Member

@CsatariGergely Apologies, I see you have do-not-merge-hold on this, I should not have LGTMd it. Anyway, it didn't go through.

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
lovesprung and others added 2 commits July 4, 2024 10:28
Signed-off-by: Schweier Dominika <dominika.schweier@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely CsatariGergely changed the title WIP: Adding Porch documentation to the docs.nephio.org Adding Porch documentation to the docs.nephio.org Jul 4, 2024
@CsatariGergely
Copy link
Contributor Author

@liamfallon now the rest of the tings were also added by @lovesprung and myself.

Ready for review.

/assign @liamfallon @ciaranjohnston

@CsatariGergely
Copy link
Contributor Author

/assign @kispaljr

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@nephio-prow nephio-prow bot added the approved label Jul 5, 2024
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon
Copy link
Member

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jul 5, 2024
Copy link
Contributor

nephio-prow bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit cca55af into nephio-project:main Jul 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Include Porch documentation
5 participants