-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Porch documentation to the docs.nephio.org #144
Conversation
Aadded files were copied from the Porch repository. Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
✅ Deploy Preview for nephio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @CsatariGergely , just some small wording comments.
Co-authored-by: Liam Fallon <35595825+liamfallon@users.noreply.github.com>
@liamfallon thanks for the suggestions, I've applied them. |
@CsatariGergely Apologies, I see you have do-not-merge-hold on this, I should not have LGTMd it. Anyway, it didn't go through. |
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Schweier Dominika <dominika.schweier@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@liamfallon now the rest of the tings were also added by @lovesprung and myself. Ready for review. /assign @liamfallon @ciaranjohnston |
/assign @kispaljr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pr adds the markdown documentation of Porch to docs.nephio.org .
Open issues are collected in here.
Fixes nephio-project/nephio#744