Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated doc to call out docker supplementary group is loaded #123

Merged
merged 1 commit into from
Apr 16, 2024
Merged

updated doc to call out docker supplementary group is loaded #123

merged 1 commit into from
Apr 16, 2024

Conversation

vjayaramrh
Copy link
Contributor

@nephio-prow nephio-prow bot requested review from efiacor and johnbelamaric April 5, 2024 16:43
@netlify Netlify
Copy link

netlify bot commented Apr 5, 2024 •
edited
Loading

✅ Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 01a891e
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/66102a2618b00f0008316ff4
😎 Deploy Preview https://deploy-preview-123--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vjayaramrh vjayaramrh self-assigned this Apr 5, 2024
@electrocucaracha
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Apr 8, 2024
@liamfallon
Copy link
Member

/lgtm
/approve

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Apr 9, 2024
@vjayaramrh
Copy link
Contributor Author

@radoslawc Wondering why the EasyCLA does not have a green check mark yet?
cc: @electrocucaracha @liamfallon

@efiacor
Copy link
Collaborator

efiacor commented Apr 9, 2024

/retest

@liamfallon
Copy link
Member

@radoslawc Wondering why the EasyCLA does not have a green check mark yet? cc: @electrocucaracha @liamfallon

I wondered about that as well. That check should be automatic.

@radoslawc radoslawc closed this Apr 16, 2024
@radoslawc radoslawc reopened this Apr 16, 2024
liamfallon
liamfallon reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@efiacor
Copy link
Collaborator

efiacor commented Apr 16, 2024

/easycla

@nephio-prow nephio-prow bot merged commit 8017ca8 into nephio-project:main Apr 16, 2024
9 checks passed
@vjayaramrh vjayaramrh deleted the docker_supplementary_group branch February 18, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamfallon liamfallon liamfallon left review comments

@efiacor efiacor Awaiting requested review from efiacor

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@rravindran123 rravindran123 Awaiting requested review from rravindran123

Assignees

@electrocucaracha electrocucaracha

@liamfallon liamfallon

@vjayaramrh vjayaramrh

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker supplementary group not reloading causes VLAN configuration failure
5 participants
@vjayaramrh @electrocucaracha @liamfallon @efiacor @radoslawc