fix(health.lua): increased version check cmd timeout #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: LspInfo returns '?' for version string when using the codeqlls language server. This is because codeql is slow to return its version number due to the underlying JVM. Solution: Increase the timeout from 300ms to 500ms. 1000 iterations of `codeql version` resulted in (349 +- 13) ms which informed the choice of 500ms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
LspInfo returns '?' for version string when using the codeqlls language server. This is because codeql is slow to return its version number due to the underlying JVM.
Solution:
Increase the timeout from 300ms to 500ms.
1000 iterations of
codeql versionresulted in (349 +- 13) ms which informed the choice of 500ms.