feat(texlab): give the find environments command a ui wrapper #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitris Dimitropoulos <dimitris.dimitropoulos00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve #3225 by filtering the output and presenting it with
vim.lsp.util.open_floating_preview. It is a pretty simple implementation that leverages builtin lua functions and basic API, therefore it should not be a burden to maintain. I have tested it locally without any major problems and i will keep testing, while making sure no issues pop up in this repo regarding this feature. I am really sure if the way the border style is setup is fitting.Here are some images:
I am totally open to any suggestions :)