Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lspconfig.Config class not modifying inherited root_dir #3243

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: lspconfig.Config class not modifying inherited root_dir #3243

merged 1 commit into from
Jul 22, 2024

Conversation

chrisgrieser
Copy link
Contributor

lspconfig.Config inherits from vim.lsp.ClientConfig, where the field root_dir is typed as string. However, for the lspconfig.Config, we are also able to set a function that returns as string.

If you are trying to use lspconfig.Config to make your own config more type-safe, this therefore throws a spurious warning.

@chrisgrieser chrisgrieser requested a review from glepnir as a code owner July 22, 2024 09:11
@glepnir glepnir merged commit 4789906 into neovim:master Jul 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants