-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add markdown-oxide lsp #3030
Conversation
16d90bf
to
1c1ec7a
Compare
b879949
to
127cdb9
Compare
@@ -0,0 +1,18 @@ | |||
return { | |||
default_config = { | |||
root_dir = function() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you can use single_file_support directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The language server uses root_dir in the initialization, so right now single_file_support does not work.
I do think that root_dir makes sense as is because this way the context in which the file is opened is sent as the root_dir, which makes sense for vaults with folders. The same root dir will be sent if neovim is called with nvim .
, nvim file
, and nvim folder/file
, which adhears to the vault structure and the LSP completion structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you set the single_file_support the root dir is cwd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As many people do track their vaults with git, I think it is best to both resolve .git as root and cwd; I think root_dir is best.
My recent commits have this
5b69bf9
to
65d207e
Compare
Co-authored-by: Raphael <glephunter@gmail.com>
Co-authored-by: Raphael <glephunter@gmail.com>
Co-authored-by: Raphael <glephunter@gmail.com>
Awesome; works on my end! |
Hey @glepnir I don't think the I believe the solution for neovim 0.9.5 is to send the cwd(), and for nightly to send the vim.uv.cwd() Shall I open a new PR? |
emm sure. but i may take a look code of there .forget some code on how neovim initialize client when root is emtpy. :p . most work on neovim core rencently .. |
Add initial support for https://github.com/Feel-ix-343/markdown-oxide