Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(denols): remove unneeded lsp attach #2000

Merged
merged 5 commits into from
Jul 17, 2022
Merged

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented Jul 14, 2022

fix #1998

I don't have a good idea how does this fixes the issue, but so far in my testing with this pr it seems to work perfectly.

fix neovim#1998

I don't have a good idea *how* do this fixes the issue, but so far in my testing with this pr it seems to work perfectly.
@sigmaSd
Copy link
Contributor Author

sigmaSd commented Jul 14, 2022

The commit that added this #753

@kitagry can you confirm that this is not needed anymore?

@justinmk justinmk changed the title fix(denols): remove unneded lsp attach fix(denols): remove unneeded lsp attach Jul 14, 2022
@kitagry
Copy link
Contributor

kitagry commented Jul 15, 2022

I added this code in order to use lsp functions (e.x. goto definition) in virtual text file. And, is it work correctly?

I'll see it this night. Thank you.

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Jul 15, 2022

Yes it seem to work inside virtual document without it.

@justinmk
Copy link
Member

lint CI is failing because of wrong indentation

@kitagry
Copy link
Contributor

kitagry commented Jul 15, 2022

Hmm, I can't reproduce this bug. Can you try with neovim develpment build?

NVIM v0.8.0-dev+1470-g0124a7bfa
Build type: Release
LuaJIT 2.1.0-beta3
nvim-lspconfig c55e830

Yes it seem to work inside virtual document without it.

I think it works only when you specify single_file_support=true.

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Jul 15, 2022

I think it works only when you specify single_file_support=true.

I can confirm this, do you have a suggestion on how to proceed then? is there a disadvantage of making single_file_support=true by default?

@kitagry
Copy link
Contributor

kitagry commented Jul 15, 2022

is there a disadvantage of making single_file_support=true by default?

I think there is no disadvantage. I think you should this PR changes with single_file_support=true by default.

@justinmk justinmk merged commit 5d77a4e into neovim:master Jul 17, 2022
sigmaSd added a commit to sigmaSd/nvim-lspconfig that referenced this pull request Aug 17, 2022
sigmaSd added a commit to sigmaSd/nvim-lspconfig that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

denols: jumping to definition then returning breaks lsp
3 participants