-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(denols): remove unneeded lsp attach #2000
Conversation
fix neovim#1998 I don't have a good idea *how* do this fixes the issue, but so far in my testing with this pr it seems to work perfectly.
I added this code in order to use lsp functions (e.x. goto definition) in virtual text file. And, is it work correctly? I'll see it this night. Thank you. |
Yes it seem to work inside virtual document without it. |
lint CI is failing because of wrong indentation |
Hmm, I can't reproduce this bug. Can you try with neovim develpment build? NVIM v0.8.0-dev+1470-g0124a7bfa
I think it works only when you specify |
I can confirm this, do you have a suggestion on how to proceed then? is there a disadvantage of making |
I think there is no disadvantage. I think you should this PR changes with |
fix #1998
I don't have a good idea how does this fixes the issue, but so far in my testing with this pr it seems to work perfectly.