Add comment explaining why it is safe to use FirstNormalTransactionXid for oldestActiveXid while replica startup #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d for oldestActiveXid while replica startup
lubennikovaav
approved these changes
Feb 22, 2024
tristan957
pushed a commit
that referenced
this pull request
May 10, 2024
…recovery. Rust's postgres_backend currently is too dummy to handle it properly: reading happens in separate thread which just ignores CopyDone. Instead, writer thread must get aware of termination and send CommandComplete. Also reading socket must be transferred back to postgres_backend (or connection terminated completely after COPY). Let's do that after more basic safkeeper refactoring and right now cover this up to make tests pass. ref #388
tristan957
pushed a commit
that referenced
this pull request
May 10, 2024
…d for oldestActiveXid while replica startup (#388) Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
tristan957
pushed a commit
that referenced
this pull request
May 20, 2024
…d for oldestActiveXid while replica startup (#388) Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
poojanilangekar
pushed a commit
to umd-dslam/sunstorm-postgres
that referenced
this pull request
Aug 26, 2024
…recovery. Rust's postgres_backend currently is too dummy to handle it properly: reading happens in separate thread which just ignores CopyDone. Instead, writer thread must get aware of termination and send CommandComplete. Also reading socket must be transferred back to postgres_backend (or connection terminated completely after COPY). Let's do that after more basic safkeeper refactoring and right now cover this up to make tests pass. ref neondatabase#388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.