Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs: fix expired token in auth decode test #6963

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

VladLazar
Copy link
Contributor

Problem

The test token expired earlier today (1709200879). I regenerated the token, but without an expiration date this time.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link
Contributor

@jcsp jcsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying that the interface is implicitly checking walltime as part of auth.decode -- would be nice to make that unit testable and have tests that check it rejects expired keys.

@VladLazar
Copy link
Contributor Author

VladLazar commented Feb 29, 2024

would be nice to make that unit testable and have tests that check it rejects expired keys.

Technically that's what it was doing :)

Copy link

2424 tests run: 2303 passed, 0 failed, 121 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_empty_branch_remote_storage_upload: release

Code coverage* (full report)

  • functions: 28.6% (6887 of 24066 functions)
  • lines: 47.1% (42128 of 89472 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
322b887 at 2024-02-29T12:04:57.768Z :recycle:

@VladLazar VladLazar enabled auto-merge (squash) February 29, 2024 13:27
@VladLazar VladLazar merged commit 5984eda into main Feb 29, 2024
52 of 53 checks passed
@VladLazar VladLazar deleted the vlad/fix-expired-token-in-test branch February 29, 2024 13:55
petuhovskiy pushed a commit that referenced this pull request Feb 29, 2024
The test token expired earlier today (1709200879). I regenerated the
token, but without an expiration date this time.
skyzh pushed a commit that referenced this pull request Mar 13, 2024
The test token expired earlier today (1709200879). I regenerated the
token, but without an expiration date this time.
skyzh pushed a commit that referenced this pull request Mar 14, 2024
The test token expired earlier today (1709200879). I regenerated the
token, but without an expiration date this time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants